summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRodolfo Carvalho <rhcarvalho@gmail.com>2017-06-09 14:28:36 +0200
committerGitHub <noreply@github.com>2017-06-09 14:28:36 +0200
commit3912fa895a2cd205cf7410e9c54f7b04dc9d9945 (patch)
tree178df3b56ade93d25d5a905b07c0e55d387e7d35
parent670e93904c7fe35dafd07148a83cd4ccaf43953d (diff)
downloadopenshift-3912fa895a2cd205cf7410e9c54f7b04dc9d9945.tar.gz
openshift-3912fa895a2cd205cf7410e9c54f7b04dc9d9945.tar.bz2
openshift-3912fa895a2cd205cf7410e9c54f7b04dc9d9945.tar.xz
openshift-3912fa895a2cd205cf7410e9c54f7b04dc9d9945.zip
Consider previous value of 'changed' when updating
This avoids unintentionally overriding the value from `True` to `False`.
-rw-r--r--roles/openshift_health_checker/openshift_checks/docker_storage.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/roles/openshift_health_checker/openshift_checks/docker_storage.py b/roles/openshift_health_checker/openshift_checks/docker_storage.py
index 5c9bed97e..7f1751b36 100644
--- a/roles/openshift_health_checker/openshift_checks/docker_storage.py
+++ b/roles/openshift_health_checker/openshift_checks/docker_storage.py
@@ -64,7 +64,7 @@ class DockerStorage(DockerHostMixin, OpenShiftCheck):
)
return {"failed": True, "changed": changed, "msg": msg}
result = self._check_dm_usage(driver_status, task_vars)
- result["changed"] = changed
+ result['changed'] = result.get('changed', False) or changed
return result
# TODO(lmeyer): determine how to check usage for overlay2