summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Gugino <mgugino@redhat.com>2017-11-02 09:48:40 -0400
committerMichael Gugino <mgugino@redhat.com>2017-11-02 09:54:16 -0400
commit6790200467b2b67e975847febefc3d7726008570 (patch)
tree330c949feb3fc23057306e93363a27860e4c3ce9
parent54d4ea101f91a244a875207e4f792d2362ea5f25 (diff)
downloadopenshift-6790200467b2b67e975847febefc3d7726008570.tar.gz
openshift-6790200467b2b67e975847febefc3d7726008570.tar.bz2
openshift-6790200467b2b67e975847febefc3d7726008570.tar.xz
openshift-6790200467b2b67e975847febefc3d7726008570.zip
Fix github auth validation
This commit ensures github auth validation filter works as intended. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1444367
-rw-r--r--roles/openshift_master_facts/filter_plugins/openshift_master.py6
1 files changed, 2 insertions, 4 deletions
diff --git a/roles/openshift_master_facts/filter_plugins/openshift_master.py b/roles/openshift_master_facts/filter_plugins/openshift_master.py
index a4f410296..69fecc7d2 100644
--- a/roles/openshift_master_facts/filter_plugins/openshift_master.py
+++ b/roles/openshift_master_facts/filter_plugins/openshift_master.py
@@ -326,10 +326,8 @@ class IdentityProviderOauthBase(IdentityProviderBase):
self._required += [['clientID', 'client_id'], ['clientSecret', 'client_secret']]
def validate(self):
- ''' validate this idp instance '''
- if self.challenge:
- raise errors.AnsibleFilterError("|failed provider {0} does not "
- "allow challenge authentication".format(self.__class__.__name__))
+ ''' validate an instance of this idp class '''
+ pass
class OpenIDIdentityProvider(IdentityProviderOauthBase):