diff options
author | Devan Goodwin <dgoodwin@redhat.com> | 2016-10-18 09:39:21 -0300 |
---|---|---|
committer | Devan Goodwin <dgoodwin@redhat.com> | 2016-10-19 10:00:30 -0300 |
commit | 3ea0166aa301990d4f95fdb1c48557e710aa0b05 (patch) | |
tree | 233baede8c077ce2d7225328121ce6155af31cb7 /roles/openshift_cli/library | |
parent | 9fa3c6c98420e4e340507193fd3ad80c15e5c19e (diff) | |
download | openshift-3ea0166aa301990d4f95fdb1c48557e710aa0b05.tar.gz openshift-3ea0166aa301990d4f95fdb1c48557e710aa0b05.tar.bz2 openshift-3ea0166aa301990d4f95fdb1c48557e710aa0b05.tar.xz openshift-3ea0166aa301990d4f95fdb1c48557e710aa0b05.zip |
Switch from "oadm" to "oc adm" and fix bug in binary sync.
Found bug syncing binaries to containerized hosts where if a symlink was
pre-existing, but pointing to the wrong destination, it would not be
corrected.
Switched to using oc adm instead of oadm.
Diffstat (limited to 'roles/openshift_cli/library')
-rw-r--r-- | roles/openshift_cli/library/openshift_container_binary_sync.py | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/roles/openshift_cli/library/openshift_container_binary_sync.py b/roles/openshift_cli/library/openshift_container_binary_sync.py index fd290c6fc..9ff738d14 100644 --- a/roles/openshift_cli/library/openshift_container_binary_sync.py +++ b/roles/openshift_cli/library/openshift_container_binary_sync.py @@ -83,8 +83,13 @@ class BinarySyncer(object): def _sync_symlink(self, binary_name, link_to): """ Ensure the given binary name exists and links to the expected binary. """ + + # The symlink we are creating: link_path = os.path.join(self.bin_dir, binary_name) - link_dest = os.path.join(self.bin_dir, binary_name) + + # The expected file we should be linking to: + link_dest = os.path.join(self.bin_dir, link_to) + if not os.path.exists(link_path) or \ not os.path.islink(link_path) or \ os.path.realpath(link_path) != os.path.realpath(link_dest): |