summaryrefslogtreecommitdiffstats
path: root/roles/openshift_health_checker
diff options
context:
space:
mode:
authorLuke Meyer <lmeyer@redhat.com>2017-06-27 14:23:27 -0400
committerLuke Meyer <lmeyer@redhat.com>2017-06-27 14:23:27 -0400
commit055f7182b78feb29909539fca86e1ef55d1fc7db (patch)
tree4147941d45f069af1f7064179f0fb2db45e33b15 /roles/openshift_health_checker
parente7be0da109ddebc99128e1829156dd8e4e6c107e (diff)
downloadopenshift-055f7182b78feb29909539fca86e1ef55d1fc7db.tar.gz
openshift-055f7182b78feb29909539fca86e1ef55d1fc7db.tar.bz2
openshift-055f7182b78feb29909539fca86e1ef55d1fc7db.tar.xz
openshift-055f7182b78feb29909539fca86e1ef55d1fc7db.zip
docker_storage check: make vgs return sane output
fix bug 1464974 https://bugzilla.redhat.com/show_bug.cgi?id=1464974 Specify --units on vgs call. In my testing with lvm 2.0.2.171(2) on RHEL Atomic Host 7.4, this turned a response of "<4.07g" into "4.07g" which should resolve the issue. I haven't found what the "<" is for in the first place but I'm thinking this should at least be a safe change.
Diffstat (limited to 'roles/openshift_health_checker')
-rw-r--r--roles/openshift_health_checker/openshift_checks/docker_storage.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/roles/openshift_health_checker/openshift_checks/docker_storage.py b/roles/openshift_health_checker/openshift_checks/docker_storage.py
index 2bd615457..8d0fbcc9c 100644
--- a/roles/openshift_health_checker/openshift_checks/docker_storage.py
+++ b/roles/openshift_health_checker/openshift_checks/docker_storage.py
@@ -143,7 +143,7 @@ class DockerStorage(DockerHostMixin, OpenShiftCheck):
"so the available storage in the VG cannot be determined.".format(pool)
)
vg_name = match.groups()[0].replace("--", "-")
- vgs_cmd = "/sbin/vgs --noheadings -o vg_free --select vg_name=" + vg_name
+ vgs_cmd = "/sbin/vgs --noheadings -o vg_free --units g --select vg_name=" + vg_name
# should return free space like " 12.00g" if the VG exists; empty if it does not
ret = self.execute_module("command", {"_raw_params": vgs_cmd}, task_vars=task_vars)